Skip to content

Feat/signer integration #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saitunc merged 30 commits into from
Dec 10, 2025
Merged

Feat/signer integration #354

saitunc merged 30 commits into from
Dec 10, 2025

Conversation

@saitunc
Copy link
Contributor

@saitunc saitunc commented Nov 21, 2025 •
edited
Loading

Signer module integration to Settlement module

This PR closes issues #302 and #301.

Changes

  • MinaSigner interface and InMemoryMinaSigner module is implemented. This module is used as a key managament system, where private keys are held here and signings are done from here. This enables settlement transactions to be signed inside InMemoryMinaSigner, without exposing private keys to any other part of the memory.
  • Besides contract keys, any Token Bridge key and their owner/admin keys are kept in the signer and retrieved by using a Map. This enables users to pass the regarding public key only - signer will find the private key and execute signings.
  • Settlement contract used to take settlementKey as input and assert that public key matches with the relevant contract. To keep private key safe, now a signature created by settlement contract key.

Commit Details

  • Implemented Signer interface and InMemoryMinaSigner : da8204c
  • Updated SettlementUtils.ts: b58840d
  • Updated bridging module: c72ce51
  • Updated settlementTestFn: 91b42b7
  • Added signature creation with a specified key on signer config e24c1e2

@saitunc saitunc requested a review from rpanic November 28, 2025 09:10
@saitunc saitunc marked this pull request as ready for review November 28, 2025 09:11
rpanic
rpanic requested changes Dec 2, 2025
View reviewed changes
rpanic
rpanic reviewed Dec 2, 2025
View reviewed changes
saitunc added 23 commits December 5, 2025 14:48
@saitunc
feat: implement a separate MinaSigner interface
466826d
@saitunc
feat: add MinaSigner interface to Settlement module
3c73e32
@saitunc
feat: change MinaSigner config type and signing logics
0c3a43c
@saitunc
refactor: update signTransaction utility function with MinaSigner
55819cd
@saitunc
refactor: update signing functions with MinaSigner based ones
ac04e3a
@saitunc
refactor: update address check in settlement contract
92632d2
@saitunc
refactor: update bridging module tx signings w/ MinaSigner
57a5579
@saitunc
refactor: inject MinaSigner optionally to SequencerStartupModule
e88e104
@saitunc
refactor: update settlementTestFn with MinaSigner functions
172b906
@saitunc
fix: resolve container is Signer instead of MinaSigner
aebb1ba
@saitunc
refactor: remove unnecessary conditional checks
cef40c0
@saitunc
style: run lint fix
743972c
@saitunc
refactor: remove keeping private keys in SettlementModule
868b15c
@saitunc
refactor: remove logs and private key config to settlement module
6429f3a
@saitunc
refactor: rename signer to feepayer to remove ambiguity
e2097f4
@saitunc
refactor: update message signing function to specify signer key
f0a65ba
@saitunc
refactor: move isSignedSEttlement to MinaBaseLayer
c2ad307
@saitunc
refactor: remove signWithContract flag in signTransaction method
59b5eb9
@saitunc
feat: add key registration to InMemoryMinaSigner
0ad1b91
@saitunc
refactor: use PublicKey instead of PrivateKey in bridging module
b480c5d
@saitunc
style: run lint fix
5982b19
@saitunc
refactor: remove additionalKeys since it is not needed
cb89177
@saitunc
fix: input of deployandinitialize after rebase in Settlement.ts
fddf408
@saitunc saitunc force-pushed the feat/signer-integration branch from 84a1bab to fddf408 Compare December 5, 2025 12:49
@saitunc saitunc requested a review from rpanic December 5, 2025 13:47
rpanic
rpanic requested changes Dec 8, 2025
View reviewed changes
@saitunc saitunc requested a review from rpanic December 8, 2025 17:51
@saitunc saitunc merged commit 1448c8e into develop Dec 10, 2025
5 checks passed
This was referenced Dec 10, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rpanic rpanic rpanic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saitunc @rpanic